From commits-return-26644-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Sat Apr 13 01:19:20 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id EC8F7180621 for ; Sat, 13 Apr 2019 03:19:19 +0200 (CEST) Received: (qmail 72186 invoked by uid 500); 13 Apr 2019 01:19:19 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 72177 invoked by uid 99); 13 Apr 2019 01:19:19 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 13 Apr 2019 01:19:19 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] [pulsar] ConcurrencyPractitioner commented on issue #4031: Feature - support seek() on Reader Message-ID: <155511835924.10295.11051235435925877019.gitbox@gitbox.apache.org> Date: Sat, 13 Apr 2019 01:19:19 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ConcurrencyPractitioner commented on issue #4031: Feature - support seek() on Reader URL: https://github.com/apache/pulsar/pull/4031#issuecomment-482764142 Sorry, just one last test case. Have you considered testing the ```seek(long startPublishTime)``` to the middle of a sequence of ids? I think ```seek(MessageId id)``` was expected to work, but what about the other seek method? If ```seek(long startPublishTime)``` works as well, then I'm all for this issue. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services