From commits-return-26299-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Tue Apr 9 00:43:11 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5772F180654 for ; Tue, 9 Apr 2019 02:43:11 +0200 (CEST) Received: (qmail 67891 invoked by uid 500); 9 Apr 2019 00:23:33 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 67882 invoked by uid 99); 9 Apr 2019 00:23:33 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Apr 2019 00:23:33 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] [pulsar] jerrypeng commented on a change in pull request #4005: Set key for message when using function publish Message-ID: <155477059071.1284.8624945563622177915.gitbox@gitbox.apache.org> Date: Tue, 09 Apr 2019 00:43:10 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit jerrypeng commented on a change in pull request #4005: Set key for message when using function publish URL: https://github.com/apache/pulsar/pull/4005#discussion_r273289025 ########## File path: pulsar-client-cpp/python/pulsar/functions/context.py ########## @@ -126,7 +126,8 @@ def record_metric(self, metric_name, metric_value): @abstractmethod def publish(self, topic_name, message, serde_class_name="serde.IdentitySerDe", properties=None, compression_type=None, callback=None): Review comment: @sijie I have updated the implementation ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services