pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] jerrypeng commented on a change in pull request #4174: [go function] support localrun and cluster mode for go function
Date Tue, 30 Apr 2019 17:52:19 GMT
jerrypeng commented on a change in pull request #4174: [go function] support localrun and cluster
mode for go function
URL: https://github.com/apache/pulsar/pull/4174#discussion_r279866171
 
 

 ##########
 File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/LocalRunner.java
 ##########
 @@ -108,6 +108,8 @@ void start() throws Exception {
                     }
                     classLoader = loadJar(file);
                 }
+            } else if (functionConfig.getRuntime() == FunctionConfig.Runtime.GO) {
+                userCodeFile = functionConfig.getGo();
 
 Review comment:
   Can we also check for python runtime here and throw an exception if its not Java, Go, or
python

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message