pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] sijie commented on a change in pull request #3915: [PIP28][PROXY] Pulsar Proxy Gateway Improvement
Date Sat, 13 Apr 2019 21:50:47 GMT
sijie commented on a change in pull request #3915: [PIP28][PROXY]  Pulsar Proxy Gateway Improvement
URL: https://github.com/apache/pulsar/pull/3915#discussion_r275133490
 
 

 ##########
 File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java
 ##########
 @@ -148,6 +148,15 @@
         doc = "Path for the file used to determine the rotation status for the proxy instance"
             + " when responding to service discovery health checks"
     )
+    private Integer proxyLogLevel = 0;
+
+    @FieldContext(
 
 Review comment:
   I think the `@FieldContext` was added to the wrong place. it should be for `proxyLogLevel`,
and the one for `proxyLogLevel` should be for `statusFilePath`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message