pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go
Date Sat, 13 Apr 2019 20:42:50 GMT
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go
URL: https://github.com/apache/pulsar/pull/3904#discussion_r275130847
 
 

 ##########
 File path: pulsar-client-go/pulsar/c_consumer.go
 ##########
 @@ -147,7 +168,12 @@ func subscribeAsync(client *client, options ConsumerOptions, callback
func(Consu
 	subName := C.CString(options.SubscriptionName)
 	defer C.free(unsafe.Pointer(subName))
 
-	callbackPtr := savePointer(&subscribeContext{conf: conf, consumer: consumer, callback:
callback})
+	var callbackPtr unsafe.Pointer
+	if schema != nil {
 
 Review comment:
   nit: I am not a go expert. but do we really need the if-else branches here? can't you just
pass a `nil` schema to the `subscribeContext` struct?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message