pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] sijie commented on a change in pull request #4022: Making use of builtin schemas for primitive types
Date Thu, 11 Apr 2019 04:25:20 GMT
sijie commented on a change in pull request #4022: Making use of builtin schemas for primitive
types
URL: https://github.com/apache/pulsar/pull/4022#discussion_r274244937
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/DoubleSchema.java
 ##########
 @@ -71,9 +74,9 @@ public Double decode(byte[] bytes) {
         }
         validate(bytes);
         long value = 0;
-        for (byte b : bytes) {
+        for (int i = 0; i < 8; i++) {
 
 Review comment:
   I am not sure why do we change here. IMO this change is irrelative. I would prefer doing
it in a separate PR if it is performance related.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message