pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] srkukarni commented on a change in pull request #4022: Making use of builtin schemas for primitive types
Date Thu, 11 Apr 2019 03:34:38 GMT
srkukarni commented on a change in pull request #4022: Making use of builtin schemas for primitive
types
URL: https://github.com/apache/pulsar/pull/4022#discussion_r274247242
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/ByteSchema.java
 ##########
 @@ -33,15 +33,15 @@ public static ByteSchema of() {
     }
 
     private static final ByteSchema INSTANCE = new ByteSchema();
-    private static final SchemaInfo SCHEMA_INFO = new SchemaInfo()
+    public static final SchemaInfo SCHEMA_INFO = new SchemaInfo()
         .setName("INT8")
         .setType(SchemaType.INT8)
         .setSchema(new byte[0]);
 
 Review comment:
   There is no equivalent schema in avro that represents byte or short. That's why I've kept
it the same.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message