pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] sijie commented on a change in pull request #3876: Add the multi version schema support
Date Tue, 09 Apr 2019 01:20:21 GMT
sijie commented on a change in pull request #3876: Add the multi version schema support
URL: https://github.com/apache/pulsar/pull/3876#discussion_r273289033
 
 

 ##########
 File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/schema/SchemaProvider.java
 ##########
 @@ -31,6 +31,14 @@
      * @param schemaVersion schema version
      * @return schema instance of the provided <tt>schemaVersion</tt>
      */
-    Schema<T> getSchema(byte[] schemaVersion);
+    Schema<T> getSchemaByVersion(byte[] schemaVersion);
+    /**
+     * Retrieve the latest schema.
+     *
+     * @return the latest schema
+     */
+    Schema<T> getLatestSchema() ;
+
+    String getTopicName();
 
 Review comment:
   add a javadoc comment for `getTopicName`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message