pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] sijie commented on a change in pull request #3992: Add exclusion for windows c++ compiler
Date Tue, 09 Apr 2019 00:32:03 GMT
sijie commented on a change in pull request #3992: Add exclusion for windows c++ compiler
URL: https://github.com/apache/pulsar/pull/3992#discussion_r273287483
 
 

 ##########
 File path: pulsar-client-cpp/lib/LogUtils.h
 ##########
 @@ -27,7 +27,11 @@
 
 namespace pulsar {
 
+#if defined _WIN32 || defined _WIN64
 
 Review comment:
   how can we test if this works for windows c++ compiler? can we have a docker based test
or vagrant based test?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message