pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] sijie commented on a change in pull request #3983: [Issue#3976] [component/client] Adding config for ReaderImpl
Date Mon, 08 Apr 2019 01:52:50 GMT
sijie commented on a change in pull request #3983: [Issue#3976] [component/client] Adding config
for ReaderImpl
URL: https://github.com/apache/pulsar/pull/3983#discussion_r272865688
 
 

 ##########
 File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ReaderBuilder.java
 ##########
 @@ -121,6 +121,13 @@
      */
     ReaderBuilder<T> startMessageId(MessageId startMessageId);
 
+    /**
+     * The initial reader positioning is done by specifying a specific timestamp.
+     * @param timestamp the timestamp where the reader will be initially positioned on
+     * @return the reader builder instance
+     */
+    ReaderBuilder<T> startMessageId(long timestamp);
 
 Review comment:
   I would suggest calling it `startPublishTime` because `timestamp` is not a message id.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message