pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] sijie commented on a change in pull request #3983: [Issue#3976] [component/client] Adding config for ReaderImpl
Date Mon, 08 Apr 2019 01:52:50 GMT
sijie commented on a change in pull request #3983: [Issue#3976] [component/client] Adding config
for ReaderImpl
URL: https://github.com/apache/pulsar/pull/3983#discussion_r272865817
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ReaderBuilderImpl.java
 ##########
 @@ -87,8 +90,13 @@ private ReaderBuilderImpl(PulsarClientImpl client, ReaderConfigurationData<T>
co
         }
 
         if (conf.getStartMessageId() == null) {
-            return FutureUtil
-                    .failedFuture(new IllegalArgumentException("Start message id must be
set on the reader builder"));
+            if (conf.getTimestamp() != -1) {
+                log.warn("Setting messageId value since timestamp value is {}", conf.getTimestamp());
 
 Review comment:
   why the log level here is `warn`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message