From commits-return-25681-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Fri Mar 29 18:29:45 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A9B18180651 for ; Fri, 29 Mar 2019 19:29:44 +0100 (CET) Received: (qmail 92108 invoked by uid 500); 29 Mar 2019 18:29:43 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 92093 invoked by uid 99); 29 Mar 2019 18:29:43 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Mar 2019 18:29:43 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] [pulsar] lovelle opened a new pull request #3946: Bugfix an unload non-existent topic Message-ID: <155388418326.24052.6338293284642804359.gitbox@gitbox.apache.org> Date: Fri, 29 Mar 2019 18:29:43 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit lovelle opened a new pull request #3946: Bugfix an unload non-existent topic URL: https://github.com/apache/pulsar/pull/3946 *Motivation* Fixes #3935 When an unload operation is being made to an non-existent topic a null pointer exception is thrown due to bad handling exception on general catch clause. *Modifications* - Simplify exception thrown when partitioned topics was not found. - Fix NPE when unload operation is being made with a non-existent topic. - Add test in order to assert unload on normal situation. - Add test to assert npe from unload with non existent topic. ### Verifying this change - [ ] Make sure that the change passes the CI checks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services