From commits-return-25552-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Thu Mar 28 06:39:40 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5FE35180629 for ; Thu, 28 Mar 2019 07:39:40 +0100 (CET) Received: (qmail 53296 invoked by uid 500); 28 Mar 2019 06:39:39 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 53277 invoked by uid 99); 28 Mar 2019 06:39:39 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Mar 2019 06:39:39 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] [pulsar] congbobo184 commented on issue #3876: Add the multi version schema support Message-ID: <155375517890.16826.4456705369069422306.gitbox@gitbox.apache.org> Date: Thu, 28 Mar 2019 06:39:38 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit congbobo184 commented on issue #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#issuecomment-477468694 > @congbobo184 overall looks much clearer now. However I think we still need to push the reader and writer schema logic to `StructSchema`. I think we need to push the reader and writer, not reader schema and writer schema. Because, from the point of view of shcema, it shouldn't have the concept of the reader schema or writer schema. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services