From commits-return-25394-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Wed Mar 27 06:19:38 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1A6CF18075F for ; Wed, 27 Mar 2019 07:19:37 +0100 (CET) Received: (qmail 96008 invoked by uid 500); 27 Mar 2019 06:19:36 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 95989 invoked by uid 99); 27 Mar 2019 06:19:36 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Mar 2019 06:19:36 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] [pulsar] MarvinCai opened a new pull request #3911: Support Kafka's ConsumerConfig.INTERCEPTOR_CLASSES_CONFIG in PulsarKafkaConsumer. Message-ID: <155366757612.10052.5029235645413520994.gitbox@gitbox.apache.org> Date: Wed, 27 Mar 2019 06:19:36 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit MarvinCai opened a new pull request #3911: Support Kafka's ConsumerConfig.INTERCEPTOR_CLASSES_CONFIG in PulsarKafkaConsumer. URL: https://github.com/apache/pulsar/pull/3911 **Motivatio** Support Kafka's ConsumerConfig.INTERCEPTOR_CLASSES_CONFIG in PulsarKafkaConsumer. close #1090 Apply onConsume in `poll()` before returning the read ConsumerRecords, apply onCommit in `doCommitOffsets()` before committing all offsets. All exception during applying onConsume/onCommit will be catch and log a message at the WARN level, it won't interrupt the normal `poll()` and `doCommitOffsets()` process. Also update doc to reflect support for ConsumerConfig.INTERCEPTOR_CLASSES_CONFIG. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services