From commits-return-25320-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org  Tue Mar 26 10:10:55 2019
Return-Path: <commits-return-25320-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 97A9218075F
	for <archive-asf-public@cust-asf.ponee.io>; Tue, 26 Mar 2019 11:10:54 +0100 (CET)
Received: (qmail 37342 invoked by uid 500); 26 Mar 2019 10:10:53 -0000
Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@pulsar.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@pulsar.apache.org>
List-Post: <mailto:commits@pulsar.apache.org>
List-Id: <commits.pulsar.apache.org>
Reply-To: dev@pulsar.apache.org
Delivered-To: mailing list commits@pulsar.apache.org
Received: (qmail 37327 invoked by uid 99); 26 Mar 2019 10:10:53 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Mar 2019 10:10:53 +0000
From: GitBox <git@apache.org>
To: commits@pulsar.apache.org
Subject: [GitHub] [pulsar] ambition119 commented on a change in pull request #3900:
 Logical type use
Message-ID: <155359505309.26022.1155615915073562686.gitbox@gitbox.apache.org>
Date: Tue, 26 Mar 2019 10:10:53 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

ambition119 commented on a change in pull request #3900: Logical type use
URL: https://github.com/apache/pulsar/pull/3900#discussion_r269025678
 
 

 ##########
 File path: pulsar-client/pom.xml
 ##########
 @@ -136,6 +136,12 @@
       <version>${project.parent.version}</version>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>joda-time</groupId>
+      <artifactId>joda-time</artifactId>
+      <version>2.10.1</version>
 
 Review comment:
   > @merlimat I think avro schema should use joda, #3856 should fix the pulsar schema. It shouldn't to change the avro schema.
   
   ok, I fix this content.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services