From commits-return-25277-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Mon Mar 25 23:39:48 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D5A9D18064C for ; Tue, 26 Mar 2019 00:39:47 +0100 (CET) Received: (qmail 70732 invoked by uid 500); 25 Mar 2019 23:39:47 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 70722 invoked by uid 99); 25 Mar 2019 23:39:46 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Mar 2019 23:39:46 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] [pulsar] srkukarni commented on a change in pull request #3874: [ISSUE 3763] - Implementing Function authorization Message-ID: <155355718646.15014.13523280804308670553.gitbox@gitbox.apache.org> Date: Mon, 25 Mar 2019 23:39:46 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit srkukarni commented on a change in pull request #3874: [ISSUE 3763] - Implementing Function authorization URL: https://github.com/apache/pulsar/pull/3874#discussion_r268896039 ########## File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/Worker.java ########## @@ -38,6 +50,13 @@ private final WorkerService workerService; private WorkerServer server; + private ZooKeeperClientFactory zkClientFactory = null; Review comment: I think @cckellogg is asking why worker needs zk in the first place? Shouldn't all information about auth service be encapsulated in the impl(in this case pulsarauthprovider) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services