From commits-return-25129-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Fri Mar 22 03:21:29 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 030AF18078F for ; Fri, 22 Mar 2019 04:21:28 +0100 (CET) Received: (qmail 86311 invoked by uid 500); 22 Mar 2019 03:21:27 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 86249 invoked by uid 99); 22 Mar 2019 03:21:27 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Mar 2019 03:21:27 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] [pulsar] merlimat commented on a change in pull request #3879: fix: ack timeout in pulsar cpp client when subscribing to regex topic Message-ID: <155322488688.19301.14652552262253846262.gitbox@gitbox.apache.org> Date: Fri, 22 Mar 2019 03:21:26 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit merlimat commented on a change in pull request #3879: fix: ack timeout in pulsar cpp client when subscribing to regex topic URL: https://github.com/apache/pulsar/pull/3879#discussion_r268027126 ########## File path: pulsar-client-cpp/tests/BasicEndToEndTest.cc ########## @@ -2940,3 +2940,50 @@ TEST(BasicEndToEndTest, testPreventDupConsumersAllowSameSubForDifferentTopics) { // consumer C should be a different instance from A and B and should be with open state. ASSERT_EQ(ResultOk, consumerC.close()); } + +static long regexTestMessagesReceived = 0; Review comment: This gets updated from one thread and read from another. We should use `std::atomic` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services