From commits-return-24316-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Mon Mar 11 01:58:53 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6AFBB180672 for ; Mon, 11 Mar 2019 02:58:53 +0100 (CET) Received: (qmail 18270 invoked by uid 500); 11 Mar 2019 01:58:52 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 18258 invoked by uid 99); 11 Mar 2019 01:58:52 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Mar 2019 01:58:52 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] [pulsar] sijie opened a new pull request #3798: Add `SkipCopyPythonClients` for building pulsar docker image Message-ID: <155226953149.29693.14174504568054877094.gitbox@gitbox.apache.org> Date: Mon, 11 Mar 2019 01:58:51 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit sijie opened a new pull request #3798: Add `SkipCopyPythonClients` for building pulsar docker image URL: https://github.com/apache/pulsar/pull/3798 *Motivation* Currently we use `skipBuildPythonClients` for controlling both building python clients and copying python clients. So we have to disable or enable all together. This introduces a problem for building pulsar docker image in a kubernetes environment (either docker-in-docker or docker-out-of-docker). An alternative approach for building pulsar docker image in a k8s environment will be: - build python client for py27 using `apachepulsar/pulsar-build:manylinux-cp27-cp27mu` in a container - build python client for py35 using `apachepulsar/pulsar-build:manylinux-cp35-cp35m` in a container - build pulsar docker image This requires separating building python clients from copying python clients. *Modifications* - introduce a new property `skipCopyPythonClients` to skip copying python clients - `skipBuildPythonClients` is only used for skipping building python clients So the above build process can be done by specifying `-DskipCopyPythonClients` ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (no) - The public API: (no) - The schema: (no) - The default values of configurations: (no) - The wire protocol: (no) - The rest endpoints: (no) - The admin cli options: (no) - Anything that affects deployment: (no) ### Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) - If a feature is not applicable for documentation, explain why? - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services