From commits-return-24292-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Sat Mar 9 13:34:27 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 521DF18067C for ; Sat, 9 Mar 2019 14:34:27 +0100 (CET) Received: (qmail 40635 invoked by uid 500); 9 Mar 2019 13:34:26 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 40617 invoked by uid 99); 9 Mar 2019 13:34:26 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Mar 2019 13:34:26 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] [pulsar] lovelle commented on a change in pull request #3795: Feature - implement reference count for ConsumerImpl Message-ID: <155213846594.27072.18171785720991990395.gitbox@gitbox.apache.org> Date: Sat, 09 Mar 2019 13:34:25 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit lovelle commented on a change in pull request #3795: Feature - implement reference count for ConsumerImpl URL: https://github.com/apache/pulsar/pull/3795#discussion_r263999419 ########## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ########## @@ -253,6 +253,10 @@ public UnAckedMessageTracker getUnAckedMessageTracker() { @Override public CompletableFuture unsubscribeAsync() { + if (!shouldTearDown()) { Review comment: Great! I was dubious about `unsubscribe`. Thanks, removed! :+1: ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services