From commits-return-23966-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Wed Mar 6 11:35:27 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C4EB218067C for ; Wed, 6 Mar 2019 12:35:26 +0100 (CET) Received: (qmail 66965 invoked by uid 500); 6 Mar 2019 11:35:25 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 66946 invoked by uid 99); 6 Mar 2019 11:35:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Mar 2019 11:35:25 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] [pulsar] ivankelly commented on a change in pull request #3677: PIP-30: interface and mutual change authentication Message-ID: <155187212534.30999.12516220215941828709.gitbox@gitbox.apache.org> Date: Wed, 06 Mar 2019 11:35:25 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ivankelly commented on a change in pull request #3677: PIP-30: interface and mutual change authentication URL: https://github.com/apache/pulsar/pull/3677#discussion_r262898418 ########## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/OneStageAuthenticationState.java ########## @@ -33,9 +36,12 @@ private final AuthenticationDataSource authenticationDataSource; private final String authRole; - public OneStageAuthenticationState(AuthenticationDataSource authenticationDataSource, + public OneStageAuthenticationState(AuthData authData, + SocketAddress remoteAddress, + SSLSession sslSession, AuthenticationProvider provider) throws AuthenticationException { - this.authenticationDataSource = authenticationDataSource; + this.authenticationDataSource = new AuthenticationDataCommand( + new String(authData.getBytes(), Charset.forName("UTF-8")), remoteAddress, sslSession);; Review comment: java.nio.charset.StandardCharsets.UTF_8 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services