From commits-return-23921-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org  Wed Mar  6 03:20:01 2019
Return-Path: <commits-return-23921-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 59F3918067C
	for <archive-asf-public@cust-asf.ponee.io>; Wed,  6 Mar 2019 04:20:01 +0100 (CET)
Received: (qmail 87798 invoked by uid 500); 6 Mar 2019 03:20:00 -0000
Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@pulsar.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@pulsar.apache.org>
List-Post: <mailto:commits@pulsar.apache.org>
List-Id: <commits.pulsar.apache.org>
Reply-To: dev@pulsar.apache.org
Delivered-To: mailing list commits@pulsar.apache.org
Received: (qmail 87786 invoked by uid 99); 6 Mar 2019 03:20:00 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Mar 2019 03:20:00 +0000
From: GitBox <git@apache.org>
To: commits@pulsar.apache.org
Subject: [GitHub] [pulsar] codelipenghui commented on a change in pull request #3752:
 revise the schema default type not null
Message-ID: <155184239964.21875.10511769794917999503.gitbox@gitbox.apache.org>
Date: Wed, 06 Mar 2019 03:19:59 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

codelipenghui commented on a change in pull request #3752: revise the schema default type not null
URL: https://github.com/apache/pulsar/pull/3752#discussion_r262779295
 
 

 ##########
 File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/internal/DefaultImplementation.java
 ##########
 @@ -182,10 +182,10 @@ public static Authentication createAuthentication(String authPluginClassName, Ma
                         .newInstance());
     }
 
-    public static <T> Schema<T> newAvroSchema(Class<T> clazz) {
+    public static <T> Schema<T> newAvroSchema(Class<T> clazz,Boolean allowNull) {
         return catchExceptions(
-                () -> (Schema<T>) getStaticMethod("org.apache.pulsar.client.impl.schema.AvroSchema", "of", Class.class)
-                        .invoke(null, clazz));
+                () -> (Schema<T>) getStaticMethod("org.apache.pulsar.client.impl.schema.AvroSchema", "of", Class.class,Boolean.class)
+                        .invoke(null, clazz,allowNull));
 
 Review comment:
   add blank space

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services