From commits-return-23620-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Mon Mar 4 16:39:24 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 588501807CA for ; Mon, 4 Mar 2019 17:39:22 +0100 (CET) Received: (qmail 82669 invoked by uid 500); 4 Mar 2019 16:39:21 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 82641 invoked by uid 99); 4 Mar 2019 16:39:21 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Mar 2019 16:39:21 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] [pulsar] sijie commented on a change in pull request #3735: Implementing authentication for Pulsar Functions Message-ID: <155171756087.5677.11430957607145258201.gitbox@gitbox.apache.org> Date: Mon, 04 Mar 2019 16:39:20 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit sijie commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r262141898 ########## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeSpawner.java ########## @@ -139,8 +139,30 @@ public void join() throws Exception { }); } + /** + * Terminates the runtime + */ @Override public void close() { + // cancel liveness checker before terminating runtime. + if (processLivenessCheckTimer != null) { + processLivenessCheckTimer.cancel(true); + processLivenessCheckTimer = null; + } + if (null != runtime) { + try { + runtime.terminate(); + } catch (Exception e) { + log.warn("Failed to terminate function runtime: {}", e, e); Review comment: you are logging two `e`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services