pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] shiv4289 opened a new pull request #3950: [ERROR] Throw error explicitly on param value not in range
Date Fri, 29 Mar 2019 21:33:36 GMT
shiv4289 opened a new pull request #3950: [ERROR] Throw error explicitly on param value not
in range
URL: https://github.com/apache/pulsar/pull/3950
 
 
   
   ### Motivation
   The code checks if value is in valid range. If yes, sets it else ignores param and returns
silently doing nothing.
   
   ### Modifications
   
   Explicitly throw IllegalArgumentException if param value not in valid range.
   
   ### Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): ( no)
     - The public API: (no)
     - The schema: ( no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
     - If yes, how is the feature documented? (not applicable )
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message