pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] sijie commented on a change in pull request #3793: Update connector download URL
Date Fri, 29 Mar 2019 04:56:02 GMT
sijie commented on a change in pull request #3793: Update connector download URL
URL: https://github.com/apache/pulsar/pull/3793#discussion_r270280618
 
 

 ##########
 File path: site2/website/scripts/replace.js
 ##########
 @@ -32,6 +32,8 @@ function binaryReleaseUrl(version) {
 function connectorReleaseUrl(version) {
     if (version.includes('incubating')) {
         return `https://archive.apache.org/dist/incubator/pulsar/pulsar-${version}/apache-pulsar-io-connectors-${version}-bin.tar.gz`
+    } else if (version >= '2.3.0') {
 
 Review comment:
   You can checkout the build script : https://github.com/apache/pulsar/blob/master/site2/tools/docker-build-site.sh
   
   You can build the content and run the replace js to replace the variables and verify the
content is displaying the download links correctly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message