pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] ivankelly commented on a change in pull request #3844: [Doc]Fix typo and language issues in the faq.md file
Date Wed, 27 Mar 2019 11:08:43 GMT
ivankelly commented on a change in pull request #3844: [Doc]Fix typo and language issues in
the faq.md file
URL: https://github.com/apache/pulsar/pull/3844#discussion_r269500916
 
 

 ##########
 File path: faq.md
 ##########
 @@ -112,162 +111,136 @@ It’s a component that was introduced recently. Essentially it’s
a stateless
 Yes, you can split a given bundle manually.
 
 ### Is the producer kafka wrapper thread-safe?
-The producer wrapper should be thread-safe.
+The producer wrapper is thread-safe.
 
 ### Can I just remove a subscription?
-Yes, you can use the cli tool `bin/pulsar-admin persistent unsubscribe $TOPIC -s $SUBSCRIPTION`.
+Yes, you can remove a subscription by using the cli tool `bin/pulsar-admin persistent unsubscribe
$TOPIC -s $SUBSCRIPTION`.
 
-### How are subscription modes set? Can I create new subscriptions over the WebSocket API?
-Yes, you can set most of the producer/consumer configuration option in websocket, by passing
them as HTTP query parameters like:
+### How to set subscription modes? Can I create new subscriptions over the WebSocket API?
+Yes, you can set most of the producer/consumer configuration option in websocket, by passing
them as HTTP query parameters as follows:
 `ws://localhost:8080/ws/consumer/persistent/sample/standalone/ns1/my-topic/my-sub?subscriptionType=Shared`
 
-see [the doc](http://pulsar.apache.org/docs/latest/clients/WebSocket/#RunningtheWebSocketservice-1fhsvp).
+You can create new subscriptions over the WebSocket API. For details, see [Pulsar's WebSocket
API](http://pulsar.apache.org/docs/latest/clients/WebSocket/#RunningtheWebSocketservice-1fhsvp).
 
 ### Is there any sort of order of operations or best practices on the upgrade procedure for
a geo-replicated Pulsar cluster?
-In general, updating the Pulsar brokers is an easy operation, since the brokers don't have
local state. The typical rollout is a rolling upgrade, either doing 1 broker at a time or
some percentage of them in parallel.
+In general, it is easy to update the Pulsar brokers, since the brokers don't have local state.
The typical rollout is a rolling upgrade, either updating a broker at a time or some percentage
of brokers in parallel.
 
-There are not complicated requirements to upgrade geo-replicated clusters, since we take
particular care in ensuring backward and forward compatibility.
+There are no complicated requirements to upgrade geo-replicated clusters, we ensure backward
and forward compatibility.
 
 Review comment:
   ```suggestion
   There are no complicated requirements to upgrade geo-replicated clusters,  as we ensure
backward and forward compatibility.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message