pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] ambition119 opened a new pull request #3902: [issue #3895] fix non-partitioned topics create error
Date Tue, 26 Mar 2019 05:50:51 GMT
ambition119 opened a new pull request #3902: [issue #3895] fix non-partitioned topics create
error
URL: https://github.com/apache/pulsar/pull/3902
 
 
   <--
   ### Contribution Checklist
     
     - Name the pull request in the form "[Issue XYZ][component] Title of the pull request",
where *XYZ* should be replaced by the actual issue number.
       Skip *Issue XYZ* if there is no associated github issue for this pull request.
       Skip *component* if you are unsure about which is the best component. E.g. `[docs]
Fix typo in produce method`.
   
     - Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   *(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
   
   Fixes #3895 
   
   ### Motivation
   
    non-partitioned topics create failed
   
   ### Modifications
   
   1. add validateTopicName function assignments topicName value.
   2. remove getOrCreateTopic avoid exceptions :
   ```java
   CompletionException: org.apache.pulsar.broker.service.BrokerServiceException$ServiceUnitNotReadyException:
Namespace bundle for topic (persistent://public/default/topic_1) not served by this instance.
Please redo the lookup. Request is denied: namespace=public/default
   ```
   3. fix internalCreateNonPartitionedTopic function non-partitioned topics create correctly.
   ```shell
   ./pulsar-admin topics create persistent://public/default/topic_1
   $ ./pulsar-admin topics partitioned-stats  persistent://public/default/topic_2
   Partitioned Topic not found
   
   Reason: Partitioned Topic not found
   ./pulsar-client produce -m "hello world test again" -n 10 topic_1
   ./pulsar-client consume -n 0 -s test topic_1
   ----- got message -----
   hello world test again
   ----- got message -----
   hello world test again
   ...
   ```
   
   
   ### Verifying this change
   
   - [对 ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API: (yes / **no**)
     - The schema: (yes / **no** / don't know)
     - The default values of configurations: (yes / **no**)
     - The wire protocol: (yes / **no**)
     - The rest endpoints: (yes / **no**)
     - The admin cli options: (yes / **no**)
     - Anything that affects deployment: (yes / **no** / don't know)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding
the documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message