pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] Jennifer88huang commented on a change in pull request #3897: [Doc]Fix typo and language issues in the adapter-kafka.md file
Date Tue, 26 Mar 2019 01:05:36 GMT
Jennifer88huang commented on a change in pull request #3897: [Doc]Fix typo and language issues
in the adapter-kafka.md file
URL: https://github.com/apache/pulsar/pull/3897#discussion_r268910926
 
 

 ##########
 File path: site2/docs/adaptors-kafka.md
 ##########
 @@ -128,20 +127,20 @@ Properties:
 
 | Config property                         | Supported | Notes                           
                                             |
 |:----------------------------------------|:----------|:------------------------------------------------------------------------------|
-| `acks`                                  | Ignored   | Durability and quorum writes are
configured at the namespace level            |
-| `auto.offset.reset`                     | Yes       | Will have a default value of `latest`
if user does not give specific setting. |
+| `acks`                                  | Ignored   | Durability and quorum writes are
configured at the namespace level.            |
+| `auto.offset.reset`                     | Yes       | If a user does not specify the setting,
the default value is `latest`. |
 | `batch.size`                            | Ignored   |                                 
                                             |
-| `block.on.buffer.full`                  | Yes       | If true it will block producer, otherwise
give error                          |
-| `bootstrap.servers`                     | Yes       | Needs to point to a single Pulsar
service URL                                 |
+| `block.on.buffer.full`                  | Yes       | When the property is set to `true`,
it blocks producer; otherwise, an error is displayed.                          |
 
 Review comment:
   ```suggestion
   | `block.on.buffer.full`                  | Yes       | When the property is set to `true`,
it blocks producer; otherwise, an error is returned.                          |
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message