pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] srkukarni commented on a change in pull request #3874: [ISSUE 3763] - Implementing Function authorization
Date Mon, 25 Mar 2019 23:39:46 GMT
srkukarni commented on a change in pull request #3874: [ISSUE 3763] - Implementing Function
authorization
URL: https://github.com/apache/pulsar/pull/3874#discussion_r268896039
 
 

 ##########
 File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/Worker.java
 ##########
 @@ -38,6 +50,13 @@
     private final WorkerService workerService;
     private WorkerServer server;
 
+    private ZooKeeperClientFactory zkClientFactory = null;
 
 Review comment:
   I think @cckellogg is asking why worker needs zk in the first place? Shouldn't all information
about auth service be encapsulated in the impl(in this case pulsarauthprovider)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message