pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] merlimat commented on a change in pull request #3879: fix: ack timeout in pulsar cpp client when subscribing to regex topic
Date Fri, 22 Mar 2019 03:21:26 GMT
merlimat commented on a change in pull request #3879: fix: ack timeout in  pulsar cpp client
when subscribing to regex topic
URL: https://github.com/apache/pulsar/pull/3879#discussion_r268027126
 
 

 ##########
 File path: pulsar-client-cpp/tests/BasicEndToEndTest.cc
 ##########
 @@ -2940,3 +2940,50 @@ TEST(BasicEndToEndTest, testPreventDupConsumersAllowSameSubForDifferentTopics)
{
     // consumer C should be a different instance from A and B and should be with open state.
     ASSERT_EQ(ResultOk, consumerC.close());
 }
+
+static long regexTestMessagesReceived = 0;
 
 Review comment:
   This gets updated from one thread and read from another. We should use `std::atomic<long>`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message