pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] jerrypeng commented on a change in pull request #3868: [Issue 3867] Provide the description of sink/source command for better usage
Date Wed, 20 Mar 2019 17:25:17 GMT
jerrypeng commented on a change in pull request #3868: [Issue 3867] Provide the description
of sink/source command for better usage
URL: https://github.com/apache/pulsar/pull/3868#discussion_r267457144
 
 

 ##########
 File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java
 ##########
 @@ -212,10 +220,6 @@ void runCmd() throws Exception {
             }
             print("Updated successfully");
         }
-
-        protected void validateSinkConfigs(SinkConfig sinkConfig) {
 
 Review comment:
   Why are we removing this? The validation logic for update sink is different than that of
create sink. By removing this logic, the validation would default to the one that is run for
creating sinks which require more fields to be specified than an update.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message