pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] sijie commented on a change in pull request #3854: [issue #3767] support go function for pulsar
Date Tue, 19 Mar 2019 12:35:07 GMT
sijie commented on a change in pull request #3854: [issue #3767] support go function for pulsar
URL: https://github.com/apache/pulsar/pull/3854#discussion_r266856778
 
 

 ##########
 File path: pulsar-function-go/pf/instance.go
 ##########
 @@ -0,0 +1,256 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package pf
+
+import (
+	"context"
+	"time"
+
+	"github.com/apache/pulsar/pulsar-client-go/pulsar"
+	"github.com/apache/pulsar/pulsar-function-go/log"
+	"github.com/apache/pulsar/pulsar-function-go/pb"
+)
+
+type GoInstance struct {
+	function  Function
+	context   *FunctionContext
+	producer  pulsar.Producer
+	consumers map[string]pulsar.Consumer
+	client    pulsar.Client
+}
+
+// NewGoInstance init GoInstance and init function context
+func NewGoInstance() *GoInstance {
+	goInstance := &GoInstance{
+		context:   NewFuncContext(),
+		consumers: make(map[string]pulsar.Consumer),
+	}
+	return goInstance
+}
+
+func (gi *GoInstance) StartFunction(function Function) {
+	gi.function = function
+	gi.setupClient()
+	err := gi.setupProducer()
+	if err != nil {
+		log.Errorf("setup producer failed, error is:%s", err.Error())
+	}
+	channel := gi.setupConsumer()
+
+CLOSE:
+	for {
+		select {
+		case cm := <-channel:
+			msgInput := cm.Message
+			output, err := gi.handlerMsg(msgInput)
+			if err != nil {
+				log.Errorf("handler message error:%v", err)
+			}
+			err = gi.processResult(msgInput, output)
+			if err != nil {
+				log.Errorf("process result error:%v", err)
+			}
+		case <-time.After(time.Millisecond * gi.context.InstanceConf.KillAfterIdleMs):
+			close(channel)
+			break CLOSE
+		}
+	}
+
+	gi.close()
+}
+
+func (gi *GoInstance) setupClient() {
+	client, err := pulsar.NewClient(pulsar.ClientOptions{
+		URL: gi.context.InstanceConf.PulsarServiceURL,
+	})
+	if err != nil {
+		log.Errorf("create client error:%v", err)
+		return
 
 Review comment:
   in line 51, you check if this call returns error or not. so don't you need to return `err`
here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message