pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] sijie commented on a change in pull request #3856: [pulsar-client] add Date/Time/Timestamp schema
Date Tue, 19 Mar 2019 12:02:28 GMT
sijie commented on a change in pull request #3856: [pulsar-client] add Date/Time/Timestamp
schema
URL: https://github.com/apache/pulsar/pull/3856#discussion_r266849341
 
 

 ##########
 File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/internal/DefaultImplementation.java
 ##########
 @@ -182,6 +185,24 @@ public static Authentication createAuthentication(String authPluginClassName,
Ma
                         .newInstance());
     }
 
+    public static Schema<Date> newDateSchema() {
+        return catchExceptions(
+                () -> (Schema<Date>) newClassInstance("org.apache.pulsar.client.impl.schema.DateSchema")
 
 Review comment:
   change this to use static method `of`, otherwise this will create a schema object for each
call

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message