pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] sijie commented on a change in pull request #3854: [issue #3767] support go function for pulsar
Date Mon, 18 Mar 2019 13:42:20 GMT
sijie commented on a change in pull request #3854: [issue #3767] support go function for pulsar
URL: https://github.com/apache/pulsar/pull/3854#discussion_r266430773
 
 

 ##########
 File path: pulsar-function-go/pf/instance.go
 ##########
 @@ -0,0 +1,289 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package pf
+
+import (
+	"context"
+	"errors"
+	"time"
+
+	"github.com/apache/pulsar/pulsar-client-go/pulsar"
+	"github.com/apache/pulsar/pulsar-function-go/log"
+	"github.com/apache/pulsar/pulsar-function-go/pb"
+)
+
+const PulsarServiceURL = "pulsar://localhost:6650"
+
+type GoInstance struct {
+	function  Function
+	context   *FunctionContext
+	producer  pulsar.Producer
+	consumers []pulsar.Consumer
+	client    pulsar.Client
+	msg       []pulsar.Message
+}
+
+func NewGoInstance() *GoInstance {
+	goInstance := &GoInstance{
+		context: NewFuncContext(),
+	}
+	return goInstance
+}
+
+type Handler struct {
+	handler Function
+}
+
+func (gi *GoInstance) handlerMsg() (output []byte, err error) {
+	ctx, cancel := context.WithCancel(context.Background())
+	defer cancel()
+	fc := NewFuncContext()
+	ctx = NewContext(ctx, fc)
+
+	if gi.msg == nil {
+		return nil, errors.New("no messages to be processed")
+	}
+	for _, msg := range gi.msg {
+		ctx = context.WithValue(ctx, "current-msg", msg)
+		ctx = context.WithValue(ctx, "current-topic", msg.Topic())
+		msgInput := msg.Payload()
+		output, err = gi.function.Process(ctx, msgInput)
+		if err != nil {
+			log.Errorf("process function err:%v", err)
+			return nil, err
+		}
+	}
+	return output, nil
+}
+
+func (gi *GoInstance) setupClient() {
+	client, err := pulsar.NewClient(pulsar.ClientOptions{
+		URL: PulsarServiceURL,
+	})
+	if err != nil {
+		log.Errorf("create client error:%v", err)
+		return
+	}
+	gi.client = client
+}
+
+func (gi *GoInstance) StartFunction(function Function) {
+	// Setup consumers and input deserializers
+	consumerType := pulsar.Shared
+	gi.context = NewFuncContext()
+	gi.setupClient()
 
 Review comment:
   move line 95 - 163 to a function `setupConsumer` and your main logic can be simplified
as followings. It will become much clearer.
   
   ```
   gi.setupFunctionContext()
   gi.setupClient()
   gi.setupProducer()
   channel  = gi.setupConsumer()
   
   CLOSE:
                for {
   			select {
   			case input := <-channel:
   				output = gi.handleMsg(input)
                                    gi.processResult(input, output)
   			case <-time.After(time.Millisecond * 500): // <= (this can be removed or renamed
to some configurable setting e.g.` killAfterIdleMs`)
   				close(channel)
   				break CLOSE
   			}
   		}
   gi.close()
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message