pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] shiv4289 commented on a change in pull request #3840: [issue 3838] [schema] : Allow incompatible schemas to co-exist on a topic
Date Sat, 16 Mar 2019 19:47:24 GMT
shiv4289 commented on a change in pull request #3840: [issue 3838] [schema] : Allow incompatible
schemas to co-exist on a topic
URL: https://github.com/apache/pulsar/pull/3840#discussion_r266212448
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/AlwaysSchemaValidator.java
 ##########
 @@ -0,0 +1,21 @@
+package org.apache.pulsar.broker.service.schema;
+
+import org.apache.avro.Schema;
+import org.apache.avro.SchemaValidationException;
+import org.apache.avro.SchemaValidator;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * An avro schema validator that always reports as compatible.
+ */
+class AlwaysSchemaValidator implements SchemaValidator {
+    private final static Logger log = LoggerFactory.getLogger(AlwaysSchemaValidator.class);
+    static AlwaysSchemaValidator INSTANCE = new AlwaysSchemaValidator();
 
 Review comment:
   Removed the logger, wasn't used. Forgot to remove after copy paste.. Great to spot the
little one 👍 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message