pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] sijie commented on a change in pull request #3793: Update connector download URL
Date Sat, 16 Mar 2019 16:05:34 GMT
sijie commented on a change in pull request #3793: Update connector download URL
URL: https://github.com/apache/pulsar/pull/3793#discussion_r266206135
 
 

 ##########
 File path: site2/website/scripts/replace.js
 ##########
 @@ -32,6 +32,8 @@ function binaryReleaseUrl(version) {
 function connectorReleaseUrl(version) {
     if (version.includes('incubating')) {
         return `https://archive.apache.org/dist/incubator/pulsar/pulsar-${version}/apache-pulsar-io-connectors-${version}-bin.tar.gz`
+    } else if (version >= '2.3.0') {
 
 Review comment:
   have you built the website locally to make sure the change work? 
   
   frankly speaking, I am not sure `version >= '2.3.0'` work

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message