pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] lovelle commented on a change in pull request #3795: Feature - implement reference count for ConsumerImpl
Date Sat, 09 Mar 2019 13:34:25 GMT
lovelle commented on a change in pull request #3795: Feature - implement reference count for
ConsumerImpl
URL: https://github.com/apache/pulsar/pull/3795#discussion_r263999419
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
 ##########
 @@ -253,6 +253,10 @@ public UnAckedMessageTracker getUnAckedMessageTracker() {
 
     @Override
     public CompletableFuture<Void> unsubscribeAsync() {
+        if (!shouldTearDown()) {
 
 Review comment:
   Great! I was dubious about `unsubscribe`.
   Thanks, removed! :+1: 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message