pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] wolfstudy commented on a change in pull request #3759: Fixes for Go client unit test
Date Thu, 07 Mar 2019 02:27:45 GMT
wolfstudy commented on a change in pull request #3759: Fixes for Go client unit test
URL: https://github.com/apache/pulsar/pull/3759#discussion_r263216289
 
 

 ##########
 File path: pulsar-client-go/pulsar/consumer_test.go
 ##########
 @@ -98,7 +100,10 @@ func TestConsumer(t *testing.T) {
 		assert.NotNil(t, msg)
 
 		assert.Equal(t, string(msg.Payload()), fmt.Sprintf("hello-%d", i))
-		assert.Equal(t, string(msg.Topic()), "persistent://public/default/my-topic")
+		assert.Equal(t, string(msg.Topic()), "persistent://public/default/" + topic)
 
 Review comment:
   ```suggestion
   		assert.Equal(t, msg.Topic(), "persistent://public/default/" + topic)
   ```
   
   The type of `msg.Topic` itself is string, we don't need to convert here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message