pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] wolfstudy opened a new issue #3774: [go client] add go related tests and checks in jenkins
Date Thu, 07 Mar 2019 01:55:13 GMT
wolfstudy opened a new issue #3774: [go client] add go related tests and checks in jenkins
URL: https://github.com/apache/pulsar/issues/3774
 
 
   **Is your feature request related to a problem? Please describe.**
   
   At present, Jenkins does not check the unit tests and code specifications related to go.
When we modify the unit test of go or add new code, we can only check it locally. For some
code formats and specifications, we have no way. Do a good job of specification and unification
   
   **Describe the solution you'd like**
   
   Regarding the check of the go code format, the more mature tool in the community is gometalinter
   
   **Additional context**
   
   check.sh
   
   ```
   #!/bin/bash
   # The script does automatic checking on a Go package and its sub-packages, including:
   # 1. gofmt         (http://golang.org/cmd/gofmt/)
   # 2. golint        (https://github.com/golang/lint)
   # 3. go vet        (http://golang.org/cmd/vet)
   # 4. gosimple      (https://github.com/dominikh/go-simple)
   # 5. unconvert     (https://github.com/mdempsky/unconvert)
   #
   # gometalinter (github.com/alecthomas/gometalinter) is used to run each static
   # checker.
   
   set -ex
   
   # Make sure gometalinter is installed and $GOPATH/bin is in your path.
   # $ go get -v github.com/alecthomas/gometalinter"
   # $ gometalinter --install"
   if [ ! -x "$(type -p gometalinter.v2)" ]; then
     exit 1
   fi
   
   linter_targets=$(go list ./...)
   
   # Automatic checks
   test -z "$(gometalinter.v2 -j 4 --disable-all \
   --enable=gofmt \
   --enable=golint \
   --enable=vet \
   --enable=gosimple \
   --enable=unconvert \
   --deadline=10m $linter_targets 2>&1 | grep -v 'ALL_CAPS\|OP_' 2>&1 | tee
/dev/stderr)"
   GO111MODULE=on go test $linter_targets
   ```
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message