pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] codelipenghui commented on a change in pull request #3752: revise the schema default type not null
Date Wed, 06 Mar 2019 03:19:59 GMT
codelipenghui commented on a change in pull request #3752: revise the schema default type not
null
URL: https://github.com/apache/pulsar/pull/3752#discussion_r262779295
 
 

 ##########
 File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/internal/DefaultImplementation.java
 ##########
 @@ -182,10 +182,10 @@ public static Authentication createAuthentication(String authPluginClassName,
Ma
                         .newInstance());
     }
 
-    public static <T> Schema<T> newAvroSchema(Class<T> clazz) {
+    public static <T> Schema<T> newAvroSchema(Class<T> clazz,Boolean allowNull)
{
         return catchExceptions(
-                () -> (Schema<T>) getStaticMethod("org.apache.pulsar.client.impl.schema.AvroSchema",
"of", Class.class)
-                        .invoke(null, clazz));
+                () -> (Schema<T>) getStaticMethod("org.apache.pulsar.client.impl.schema.AvroSchema",
"of", Class.class,Boolean.class)
+                        .invoke(null, clazz,allowNull));
 
 Review comment:
   add blank space

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message