pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] sijie commented on a change in pull request #3722: Retry creation of assignment topic a few times before giving up
Date Mon, 04 Mar 2019 16:42:14 GMT
sijie commented on a change in pull request #3722: Retry creation of assignment topic a few
times before giving up
URL: https://github.com/apache/pulsar/pull/3722#discussion_r262144333
 
 

 ##########
 File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/SchedulerManager.java
 ##########
 @@ -105,25 +105,12 @@ public SchedulerManager(WorkerConfig workerConfig, PulsarClient pulsarClient,
Pu
                     .compressionType(CompressionType.LZ4)
                     .sendTimeout(0, TimeUnit.MILLISECONDS)
                     .createAsync().get(10, TimeUnit.SECONDS);
+            } catch (Exception e) {
 
 Review comment:
   I don't think we should retry at `InterruptedException` and also when `InterruptedException`
is caught, you should propagate the interrupted bit to your outer thread `Thread.currentThread().interrupt()`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message