pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] sijie commented on a change in pull request #3735: Implementing authentication for Pulsar Functions
Date Mon, 04 Mar 2019 16:39:20 GMT
sijie commented on a change in pull request #3735: Implementing authentication for Pulsar Functions
URL: https://github.com/apache/pulsar/pull/3735#discussion_r262136164
 
 

 ##########
 File path: pulsar-functions/proto/src/main/proto/Function.proto
 ##########
 @@ -141,6 +141,11 @@ message FunctionMetaData {
     uint64 version = 3;
     uint64 createTime = 4;
     map<int32, FunctionState> instanceStates = 5;
+    FunctionAuthenticationSpec functionAuthSpec = 6;
+}
+
+message FunctionAuthenticationSpec {
+    string data = 1;
 
 Review comment:
   I am wondering why are you using `string`, not `bytes`. my concern of `string` is that
encoding with locales make things very tricky and hard to debug.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message