pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] ivankelly commented on a change in pull request #3677: PIP-30: interface and mutual change authentication
Date Mon, 04 Mar 2019 11:36:37 GMT
ivankelly commented on a change in pull request #3677: PIP-30: interface and mutual change
authentication
URL: https://github.com/apache/pulsar/pull/3677#discussion_r262023365
 
 

 ##########
 File path: pulsar-common/src/main/java/org/apache/pulsar/common/api/Commands.java
 ##########
 @@ -150,6 +152,48 @@ public static ByteBuf newConnect(String authMethodName, String authData,
int pro
         return res;
     }
 
+    public static ByteBuf newConnect(String authMethodName, AuthData authData, int protocolVersion,
String libVersion,
+                                     String targetBroker, String originalPrincipal, String
originalAuthData,
+                                     String originalAuthMethod) {
+        CommandConnect.Builder connectBuilder = CommandConnect.newBuilder();
+        connectBuilder.setClientVersion(libVersion != null ? libVersion : "Pulsar Client");
+        connectBuilder.setAuthMethodName(authMethodName);
+
+        if ("ycav1".equals(authMethodName)) {
 
 Review comment:
   Can this happen? Won't it be blocked because it has a higher protocol version?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message