pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] eolivelli commented on a change in pull request #3677: PIP-30: interface and mutual change authentication
Date Fri, 01 Mar 2019 12:18:11 GMT
eolivelli commented on a change in pull request #3677: PIP-30: interface and mutual change
authentication
URL: https://github.com/apache/pulsar/pull/3677#discussion_r261581167
 
 

 ##########
 File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationService.java
 ##########
 @@ -105,6 +105,18 @@ public String authenticateHttpRequest(HttpServletRequest request) throws
Authent
         }
     }
 
+    public AuthenticationProvider getAuthenticationProvider(String authMethodName) {
+        return providers.get(authMethodName);
+    }
+
+    public String getAnonymousUserRole() throws AuthenticationException {
+        if (StringUtils.isNotBlank(anonymousUserRole)) {
+            return anonymousUserRole;
+        }
+        // If at least a provider was configured, then the authentication needs to be provider
 
 Review comment:
   Typo: provider -> provided

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message