From commits-return-23105-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Mon Feb 25 20:47:55 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id BDCC1180626 for ; Mon, 25 Feb 2019 21:47:54 +0100 (CET) Received: (qmail 14477 invoked by uid 500); 25 Feb 2019 20:47:53 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 14462 invoked by uid 99); 25 Feb 2019 20:47:53 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Feb 2019 20:47:53 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] jerrypeng opened a new pull request #3684: fix: non-batched messages cause sql query to fail Message-ID: <155112767323.24020.4355971741637808712.gitbox@gitbox.apache.org> Date: Mon, 25 Feb 2019 20:47:53 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit jerrypeng opened a new pull request #3684: fix: non-batched messages cause sql query to fail URL: https://github.com/apache/pulsar/pull/3684 ### Motivation Because of error as describe in: https://github.com/apache/pulsar/issues/3679 If messages published by a producer that does not have batching enabled with cause Pulsar SQL queries to fail because of IllegalReferenceCountException. ### Modifications Call retain for non-batched message payloads to increment the reference count just as wha is done for batched messages ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services