From commits-return-22666-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Wed Feb 20 03:34:37 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2448E18077A for ; Wed, 20 Feb 2019 04:34:36 +0100 (CET) Received: (qmail 16355 invoked by uid 500); 20 Feb 2019 03:34:35 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 16333 invoked by uid 99); 20 Feb 2019 03:34:35 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Feb 2019 03:34:35 +0000 From: GitBox To: commits@pulsar.apache.org Subject: =?utf-8?q?=5BGitHub=5D_merlimat_commented_on_a_change_in_pull_request_=23?= =?utf-8?q?3627=3A_Pulsar_Startup_Script_fixes_to_provide_custom_conf_file?= =?utf-8?q?s_for_bookie_s=E2=80=A6?= Message-ID: <155063367489.29452.4109270460544189303.gitbox@gitbox.apache.org> Date: Wed, 20 Feb 2019 03:34:34 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit merlimat commented on a change in pull request #3627: Pulsar Startup Script fixes to provide custom conf files for bookie s… URL: https://github.com/apache/pulsar/pull/3627#discussion_r258322644 ########## File path: bin/pulsar ########## @@ -221,7 +221,6 @@ fi if [ -z "$PULSAR_GLOBAL_ZK_CONF" ]; then PULSAR_GLOBAL_ZK_CONF=$DEFAULT_GLOBAL_ZK_CONF - PULSAR_CONFIGURATION_STORE_CONF=$DEFAULT_GLOBAL_ZK_CONF Review comment: This seems to be unrelated with the PR ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services