From commits-return-22427-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Wed Feb 13 23:47:13 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B26F61807A6 for ; Thu, 14 Feb 2019 00:47:12 +0100 (CET) Received: (qmail 1644 invoked by uid 500); 13 Feb 2019 23:47:11 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 1626 invoked by uid 99); 13 Feb 2019 23:47:11 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Feb 2019 23:47:11 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] merlimat commented on a change in pull request #3568: Refresh Certs every X minutes Message-ID: <155010163121.23122.7495721641290071690.gitbox@gitbox.apache.org> Date: Wed, 13 Feb 2019 23:47:11 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit merlimat commented on a change in pull request #3568: Refresh Certs every X minutes URL: https://github.com/apache/pulsar/pull/3568#discussion_r256638780 ########## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/AuthenticationDataProvider.java ########## @@ -40,6 +40,22 @@ default boolean hasDataForTls() { return false; } + + /** + * + * @return a Client Certificate File Path, or null if data is not available + */ + default String getCertFilePath() { Review comment: Again, I don't think it's a good option to have these 2 here, since the auth data provider is not specific to TLS. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services