pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jiazhai commented on a change in pull request #3677: PIP-30: interface and mutual change authentication
Date Thu, 28 Feb 2019 12:11:27 GMT
jiazhai commented on a change in pull request #3677: PIP-30: interface and mutual change authentication
URL: https://github.com/apache/pulsar/pull/3677#discussion_r261167057
 
 

 ##########
 File path: pulsar-common/src/main/proto/PulsarApi.proto
 ##########
 @@ -197,6 +197,10 @@ message CommandConnect {
 message CommandConnected {
 	required string server_version = 1;
 	optional int32 protocol_version = 2 [default = 0];
+
 
 Review comment:
   Thanks @ivankelly.  If you are agree, would like to re-use connect command. 
   Actually,  auth flow is indeed part of connect flow, and the original auth method is part
of the connect logic. 
   Reuse the connect command here is also earlier for the backward compatible.  If provide
a new AuthData, the `CommandConnect` in above is better to keep align, and change `auth_method_name`
and `auth_data` into the new AuthData.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message