pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie commented on a change in pull request #3696: fix elasticsearch in pom Consistent with other IOs
Date Thu, 28 Feb 2019 10:57:00 GMT
sijie commented on a change in pull request #3696: fix elasticsearch in pom Consistent with
other IOs
URL: https://github.com/apache/pulsar/pull/3696#discussion_r261142884
 
 

 ##########
 File path: pulsar-io/elastic-search/pom.xml
 ##########
 @@ -56,13 +56,12 @@
     <dependency>
       <groupId>org.apache.commons</groupId>
       <artifactId>commons-lang3</artifactId>
-      <version>3.4</version>
     </dependency>
 
   	<dependency>
   		<groupId>org.elasticsearch.client</groupId>
   		<artifactId>elasticsearch-rest-high-level-client</artifactId>
-  		<version>6.3.2</version>
+  		<version>${elasticsearch.version}</version>
 
 Review comment:
   @ambition119 in pulsar, we try to manage all the dependencies in one single place (dependencyManagement
at root pom file), so it is easier to find the versions at single place. the only exception
we do is when there are version conflicts, we add overwrites when using that jar.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message