pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] srkukarni commented on a change in pull request #3706: Fail the source record if the write fails
Date Thu, 28 Feb 2019 05:16:48 GMT
srkukarni commented on a change in pull request #3706: Fail the source record if the write
fails
URL: https://github.com/apache/pulsar/pull/3706#discussion_r261049081
 
 

 ##########
 File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/sink/PulsarSink.java
 ##########
 @@ -268,7 +270,7 @@ public void open(Map<String, Object> config, SinkContext sinkContext)
throws Exc
     }
 
     @Override
-    public void write(Record<T> record) throws Exception {
 
 Review comment:
   because nothing ever throws any exception in the code

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message