pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] eolivelli commented on a change in pull request #3677: [WIP]PIP-30: interface and mutual change authentication
Date Sat, 23 Feb 2019 15:05:56 GMT
eolivelli commented on a change in pull request #3677: [WIP]PIP-30: interface and mutual change
authentication
URL: https://github.com/apache/pulsar/pull/3677#discussion_r259581668
 
 

 ##########
 File path: pulsar-common/src/main/java/org/apache/pulsar/common/api/Commands.java
 ##########
 @@ -168,6 +210,21 @@ public static ByteBuf newConnected(int clientProtocolVersion) {
         return res;
     }
 
+    public static ByteBuf newConnecting(String authMethod, byte[] authData) {
+        CommandConnected.Builder connectedBuilder = CommandConnected.newBuilder();
+        connectedBuilder.setServerVersion("Pulsar Server Mutual Authn");
 
 Review comment:
   If this a version why doesn't it include the actual version (like 2.3.0)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message